Query Language or Method calls: A matter of taste
My last post (which was too long ago), generated question on whether I prefer the query language or the method notation for LINQ queries.
The answer is ‘yes’. Jon Skeet mentioned this as well last January, but anything you can do with query syntax can be accomplished with method calls. (Item 36 of More Effective C# discusses is some detail how the query language operators map to method calls.)
From the standpoint of correctness, you can use either construct with no differences. That means it is a matter of style whether you choose the query expressions or the method calls.
My own preference is to use the method call syntax for simpler queries, and use the query syntax for more complex query operations.
For example, I would use the method call syntax below over the query syntax:
1: int[] numbers = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 };
2: var smallNumbers = from n in numbers
3: where n < 5
4: select n;
5:
6: var smallNumbers2 = numbers.Where((n) => n < 5);
However, once a query gets sufficiently complex, I believe the query syntax is more readable:
1: int[] odds = { 1, 3, 5, 7 };
2: int[] evens = { 2, 4, 6, 8 };
3: var values = from oddNumber in odds
4: from evenNumber in evens
5: where oddNumber > evenNumber
6: select new { oddNumber, evenNumber,
7: Sum = oddNumber + evenNumber };
8:
9: var values2 = odds.SelectMany(oddNumber => evens,
10: (oddNumber, evenNumber) =>
11: new { oddNumber, evenNumber })
12: .Where(pair => pair.oddNumber > pair.evenNumber).
13: Select(pair => new {
14: pair.oddNumber,
15: pair.evenNumber,
16: Sum = pair.oddNumber + pair.evenNumber });
In my opinion, for more complex queries, the query language produces a much more readable construct. However, on simpler queries, the method calls are easier to understand.
I like Jon’s comment: “next time you’re writing a query expression, take a look at it afterwards – it it’s simple, try writing it without the extra syntactic sugar.” (from the post referenced above).